Repository navigation
Updating to jadonk - #1
Merged
Merged
Conversation
Updated for Blue GPIO pins
printing out the socket response from the browser shows the hostname as : http:// [object] [method] :80
had to modify both the client and server since the method of translation at the client side will throw the deprecation warning even if node_style callbacks are used,confirmed working of both style callbacks, needs to add test-case
test cases not added for hw_... dependent cases
…ases hw_simulator modified to support nodestyle callbacks,added tests for previously omitted cases
also changed console messages and function names on test-rpc.js from ..._previous to ..._oldstyle
Support nodestyle callbacks
add code comments wherever necessary for changes made as part of GSoC '18 work
used express-session middleware to handle the session(added as dependency) used basic-auth to handle authentication(added as dependency) modify the startclient to send cookie data modify the startServer to accept credentials tested both from browser and via node, works well
originally written by @troywweber7 also submitted to @types : DefinitelyTyped/DefinitelyTyped#26814
authentication at express level was removed and was implemented at
the socket.io connection through extraheaders, corresponding modification
was made at server and client
* username & password send as basic authentication headers
* modified server.js to read config file from /etc/default/bonescript
the config file format used was :
{
"username":"debian",
"password":"temppwd",
"port": 8000 ,
"directory": "/usr/share/bone101"
}
* need to add more test cases and make other improvements
expression session dependency was removed and simple socket.io middleware
hash-challenge was used for authentication, modified the client and
server for the changes the passphrase can be supplied to serverstart already
as hash or as plaintext: the configuration files used for testing server.js were:
{
"hash": true,
"passphrase":"9f735e0df9a1ddc702bf0a1a7b83033f9f7153a00c29de82cedadc9957289b05",
"port": 8000 ,
"directory": "/usr/share/bone101"
}
and
{
"hash": false,
"passphrase":"testpassword",
"port": 8000 ,
"directory": "/usr/share/bone101"
}
also other unnecessary dependencies were removed, need to add test cases
modified rpc tests to increase converage added analogWrite(), digitalWrite() and pinMode() tests modified test-ffi to include callback cases added test-math based on pattern of math functions added test-digitalRead() and test-analogRead()
in the case of analogWrite() on digital out, the callbacks were invoked twice everytime, found while writing a test-case
the callback on digitalWrite on AnalogOut was never invoked due to error in arguments supplied to analogWrite()
add session based authentication for rpc
change function return value type to any removed getEeproms definition defined platform object structure removed unnecesary exports
add TypeScript definitions
changes made to node-roboticscape: jadonk/node-roboticscape#5 tested on: BeagleBone Blue BeagleBoard.org Debian Image 2018-03-05 Linux beaglebone 4.9.105-ti-r113 rc_version : 0.4.4
add rcServo,rcIMU,rcBMP functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.